Skip to content

Conversation

@zhjwpku
Copy link
Collaborator

@zhjwpku zhjwpku commented Jun 20, 2025

No description provided.

@zhjwpku
Copy link
Collaborator Author

zhjwpku commented Jun 20, 2025

I checked the gh actions prior to #119, the logs say our builds contained warnings (see [1]).
To prevent introducing additional warnings in the future, I propose to enable compile warning as error.

[1] https://github.com/apache/iceberg-cpp/actions/runs/15406978076/job/43351431102?pr=113#step:3:192

@zhjwpku
Copy link
Collaborator Author

zhjwpku commented Jun 20, 2025

Oops, it found a few more warnings on windows platform. Do you think it’s worth addressing these? @wgtmac @lidavidm

https://github.com/apache/iceberg-cpp/actions/runs/15777841435/job/44476206590?pr=125#step:4:589

@lidavidm
Copy link
Member

MSVC tends to be oddly finicky but it's probably worth fixing those

@Fokko Fokko merged commit 9243ff4 into apache:main Jun 27, 2025
7 checks passed
@Fokko
Copy link
Contributor

Fokko commented Jun 27, 2025

Let's move this forward, thanks @zhjwpku for working on this, and thanks @lidavidm, @wgtmac and @mapleFU for the review!

@zhjwpku zhjwpku deleted the enable_compile_warning_as_error branch June 28, 2025 08:37
lishuxu pushed a commit to lishuxu/iceberg-cpp that referenced this pull request Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants